ARROW-8770: [C++][CI] Enable arrow-csv-test on s390x#7152
Closed
kiszk wants to merge 1 commit intoapache:masterfrom
Closed
ARROW-8770: [C++][CI] Enable arrow-csv-test on s390x#7152kiszk wants to merge 1 commit intoapache:masterfrom
kiszk wants to merge 1 commit intoapache:masterfrom
Conversation
Member
Author
|
Now, we can see |
pitrou
reviewed
May 12, 2020
| ulimit -c unlimited || : | ||
| - | | ||
| archery docker run \ | ||
| -e ARROW_CSV=${ARROW_CSV:-ON} \ |
Member
Author
There was a problem hiding this comment.
I was suggested to remove a line at archery docker run in the previous PR when a new flag was enabled. cc @kou
Member
There was a problem hiding this comment.
We don't need it if we don't need to change the default -DARROW_CSV.
If we have multiple default definitions, they will confuse us.
pitrou
approved these changes
May 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables arrow-csv-test on TravisCI on s390x. This testsuite can pass with the latest master.